Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception handling with session logging #788

Closed
wants to merge 1 commit into from

Conversation

crowar
Copy link

@crowar crowar commented Aug 31, 2023

Refactored the way that exceptions during a disposed session are handled. Instead of writing it directly to a generic local file, it now writes it to a file located in the defined log path of the Initiator. This will make management easier and more consistent. Furthermore, the code block has been simplified, reducing its overhead.

In Addition, a method GetLogPath() was added to the AbstractInitiator class. This encapsulates the logic to fetch the log file path and allows the subclasses to reuse this method. If the FILE_LOG_PATH is not defined in session settings, a default current directory path (".") is returned.

Refactored the way that exceptions during a disposed session are handled. Instead of writing it directly to a generic local file, it now writes it to a file located in the defined log path of the Initiator. This will make management easier and more consistent. Furthermore, the code block has been simplified, reducing its overhead.

In Addition, a method GetLogPath() was added to the AbstractInitiator class. This encapsulates the logic to fetch the log file path and allows the subclasses to reuse this method. If the FILE_LOG_PATH is not defined in session settings, a default current directory path (".") is returned.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nikolay Sulimov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gbirchmeier
Copy link
Member

In #830, I merged a more-extensive rewrite of our hacky "debug log" behavior, which did include this code in your PR. Please take a look.

Thanks for your proposed contribution though!

@gbirchmeier gbirchmeier closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants