Feature/new logging #743
Closed
Feature/new logging #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Separate to the main point of this PR: I do like the regrouping that you did, but I think that should be a separate standalone PR. |
|
I respect the work that was done, but it's really stale now, and I'm not sure if this is the right way to go anyway. I think this year I'm going to try to push some kind of logging revision, and I will be consulting with contributing devs for the best approach. Stay tuned to the mailing list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i have tried to migrate the current logging setup to the new .Net Abstractions Logging Setup.
I created some wrappers which allow to still use the "old" versions and extended the "old" Logger to support the new framework.
What is maybe a bit confusing, "old" ILogFactory does not correspond to the new ILoggerFactory but more to the ILoggerProvider interface from my point of view.
If you have any questions, just let me know.
P.S. I have migrated all the .Net Core projects to 3.1. which I think is the only still valid version possible without touching the breaking changes of .Net 5.0. #713