Add followers to AWS Cluster demo #32
Conversation
demos/aws-cluster/1.1_init_followers
Outdated
|
|
||
| mkdir -p $SEED_DIR | ||
|
|
||
| # Create Standby Seed |
There was a problem hiding this comment.
Comment should read Create Follower Seed.
| -o "StrictHostKeyChecking no" \ | ||
| core@$MASTER_1_PUBLIC /bin/bash << EOF | ||
| docker exec conjur-appliance bash -c " \ | ||
| evoke seed follower "$LB_FOLLOWER_DNS" "$LB_DNS" > "/opt/conjur/backup/$filename" |
There was a problem hiding this comment.
Why do you include $LB_DNS here?
There was a problem hiding this comment.
Last I checked on it, it was still not crystal clear what is the correct way to setup certificates and domain names for an autofailover cluster to work with load balancers. So I was explicit about what the master address should be for the follower to avoid any issues while preparing the PCF demo video.
It's possible that it's not necessary. I can create an issue to investigate removing it.
|
|
||
| create_follower_seed "follower-seed.tar" | ||
|
|
||
| configure_followers |
There was a problem hiding this comment.
In some other projects, we adhere to Google shell guidelines that state to create a main function at the top of the file and call it at the bottom so that it's easy to find the program start. I know the way you did this is more consistent with the other files in this repo so maybe it's better to follow the established standard here but thought it was worth raising.
There was a problem hiding this comment.
Cool, I did not know about this! I'm not going to change it now because I would need to run through it all again to make sure I didn't break anything. I will create an issue to refactor this according to these guidelines next time I'm in here. Thanks!
micahlee
force-pushed
the
aws-cluster-followers
branch
from
7188e93 to
39a419a
Compare
|
Thanks @jtuttle! I fixed the typo and added follow up issues for the others. Let me know what you think! |
Quickstart Flow Automation in Actions
This PR updates the AWS Cluster demo to add AWS instances for followers and a script to optionally configure them.
Connected to #33