Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create repsetdata script #111
base: sel-rep-codi
Are you sure you want to change the base?
Create repsetdata script #111
Changes from 2 commits
0afa7e1
533dc67
450e307
dd9fa79
5a7f4ff
b98a088
4a70e18
0c8f9e1
3efdc33
180939a
6e6cf35
fb030bf
cef82d3
1b7de92
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
replication_sets
column is of the format{repset1,repset2,repset3}
Since the script outputs a CSV, we may want to confirm that if a variable belongs to multiple replication sets, the output does not get mangled if each replication set is considered a separate column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imheresamir We looked at this yesterday and multiple replication sets will be in a single column. However that was before we removed the leading or trailing { }. I'll let @kmacinnis confirm and check if this will causes issue..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local testing results in the following:
Which could be ok depending on requirements. I would expect there to be separate lines for each replication set for each variable belonging to multiple replication sets, like this:
That way the
ReplicationSet
column can be filtered in Excel.