Allow execute request with simple action tag #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas0087
force-pushed
the
execute-simple-action-tag
branch
2 times, most recently
from
a0b5b91
to
4acfa64
Compare
|
Thanks @thomas0087 . I'll check out the test issue and get back to you. Can you give me some details on the Dynamics server? What version? Is it hosted or on-premise? |
|
Hi @jheth, It's an on-premise hosted server, here are the version details |
|
@thomas0087 Can you re-base to see if the build issue is resolved? |
jheth
reviewed
Nov 5, 2016
| @@ -302,10 +302,12 @@ def execute_request(action, parameters={}) | |||
| ns_alias = 'a' | |||
| end | |||
|
|
|||
| action_tag = (include_action ? %Q{<request i:type="#{ns_alias}:#{action}Request" xmlns:a="http://schemas.microsoft.com/xrm/2011/Contracts" xmlns:b="http://schemas.microsoft.com/crm/2011/Contracts">} : '<request xmlns:a="http://schemas.microsoft.com/xrm/2011/Contracts">') | |||
There was a problem hiding this comment.
Can you make this a regular if/else, the line length runs off the page.
thomas0087
force-pushed
the
execute-simple-action-tag
branch
from
4acfa64
to
57d4325
Compare
|
Hi @jheth, I've split the if statement and the specs are all green after the rebase 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dynamics server we are interacting with has some custom methods that don't conform to the same format as the
execute_requestmethod uses. This PR adds the ability to exclude the action name from the request tag.The specs seem to be failing because psavtest.crm.powerobjects.net doesn't resolve.