Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KREST-2521 fixing consumer lag list failure #911

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ahuang98
Copy link
Member

@ahuang98 ahuang98 commented Sep 21, 2021

@ahuang98
Copy link
Member Author

confirmed we get the same test error from insufficient poll time
https://jenkins.confluent.io/job/Confluentinc%20Contributors/job/kafka-rest/job/PR-911/5/testReport/junit/io.confluent.kafkarest.integration.v3/ConsumerLagsResourceIntegrationTest/listConsumerLags_returnsConsumerLags/

java.lang.AssertionError: Failed after 2987 ms elapsed and 3 exponential backoff retries with 200 ms initial retry interval.
	at io.confluent.kafkarest.integration.v3.ConsumerLagsResourceIntegrationTest.listConsumerLags_returnsConsumerLags(ConsumerLagsResourceIntegrationTest.java:107)
Caused by: java.util.NoSuchElementException: No value present
	at io.confluent.kafkarest.integration.v3.ConsumerLagsResourceIntegrationTest.lambda$listConsumerLags_returnsConsumerLags$2(ConsumerLagsResourceIntegrationTest.java:128)
	at io.confluent.kafkarest.integration.v3.ConsumerLagsResourceIntegrationTest.listConsumerLags_returnsConsumerLags(ConsumerLagsResourceIntegrationTest.java:107)

@dimitarndimitrov
Copy link
Member

I'm OK with the approach even if not ideal, but I have to wonder - unless this was failing in 100% of the cases (I don't think it was, although I might be wrong), is a single passing PR CI run a reliable validation for the fix? I can imagine how this can reduce the failure rate, but unless there's a qualitative change, I think we will be left in roughly the same spot that we were in.

In case this can be reproduced locally, I think we should check what is the failure rate from 100 runs before vs after.

  • I think something like for i in {1..100}; do mvn -f kafka-rest/pom.xml -Dit.test= ConsumerLagsResourceIntegrationTest test-compile failsafe:integration-test >> ~/Downloads/KREST-2521.log; done should work, although that's in the not so common case where the failure can be reproduced locally...

Copy link

cla-assistant bot commented Sep 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dimitarndimitrov
Copy link
Member

@ahuang98 Is this still relevant? I assume it's not and we can close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants