Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for errors during performance test by checking HTTP status. #19

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Check for errors during performance test by checking HTTP status. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/main/java/io/confluent/kafkarest/tools/ConsumerPerformance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.confluent.kafkarest.Versions;
import io.confluent.kafkarest.entities.ConsumerInstanceConfig;
import io.confluent.kafkarest.entities.CreateConsumerInstanceResponse;
import io.confluent.rest.entities.ErrorMessage;

public class ConsumerPerformance extends AbstractPerformanceTest {

Expand All @@ -39,6 +40,8 @@ public class ConsumerPerformance extends AbstractPerformanceTest {
String deleteUrl;
long consumedRecords = 0;

private final ObjectMapper jsonDeserializer = new ObjectMapper();

public static void main(String[] args) throws Exception {
if (args.length < 4) {
System.out.println(
Expand Down Expand Up @@ -120,22 +123,27 @@ private <T> T request(String target, String method, byte[] entity, String entity
if (entity != null) {
connection.setRequestProperty("Content-Type", Versions.KAFKA_MOST_SPECIFIC_DEFAULT);
connection.setRequestProperty("Content-Length", entityLength);
connection.setDoInput(true);
}

connection.setDoInput(true);
connection.setUseCaches(false);
if (method != "DELETE") {
connection.setDoOutput(true);
}

if (entity != null) {
connection.setDoOutput(true);
OutputStream os = connection.getOutputStream();
os.write(entity);
os.flush();
os.close();
}

if (method != "DELETE") {
int responseStatus = connection.getResponseCode();
if (responseStatus >= 400) {
InputStream es = connection.getErrorStream();
ErrorMessage errorMessage = jsonDeserializer.readValue(es, ErrorMessage.class);
es.close();
throw new RuntimeException(
String.format("Unexpected HTTP error status %d for %s request to %s: %s",
responseStatus, method, target, errorMessage.getMessage()));
}
if (responseStatus != HttpURLConnection.HTTP_NO_CONTENT) {
InputStream is = connection.getInputStream();
T result = serializer.readValue(is, responseFormat);
is.close();
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/io/confluent/kafkarest/tools/ProducerPerformance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import io.confluent.kafkarest.Versions;
import io.confluent.kafkarest.entities.TopicProduceRecord;
import io.confluent.kafkarest.entities.TopicProduceRequest;
import io.confluent.rest.entities.ErrorMessage;

public class ProducerPerformance extends AbstractPerformanceTest {

Expand All @@ -39,6 +40,8 @@ public class ProducerPerformance extends AbstractPerformanceTest {
byte[] requestEntity;
byte[] buffer;

private final ObjectMapper jsonDeserializer = new ObjectMapper();

public static void main(String[] args) throws Exception {
if (args.length < 6) {
System.out.println(
Expand Down Expand Up @@ -103,6 +106,15 @@ protected void doIteration(PerformanceStats.Callback cb) {
os.flush();
os.close();

int responseStatus = connection.getResponseCode();
if (responseStatus >= 400) {
InputStream es = connection.getErrorStream();
ErrorMessage errorMessage = jsonDeserializer.readValue(es, ErrorMessage.class);
es.close();
throw new RuntimeException(
String.format("Unexpected HTTP error status %d: %s",
responseStatus, errorMessage.getMessage()));
}
InputStream is = connection.getInputStream();
while (is.read(buffer) > 0) {
// Ignore output, just make sure we actually receive it
Expand Down