Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix online brokers, zookeepers issues and add 2.5DC dashboard in ELK stack #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hanxnow77
Copy link

Add AOP monitoring metrics and widgets into Kafka Overview 2.5dc dashboard, including:

  • In Sync Replicas Count
  • Caught Up Replicas Count
  • Observers In Isr Count
  • Is Not Caught Up
    Fix "Online Broker" in Kafka Overview dashboard
    Add "ZooKeeper Quorum Size" in Zookeeper Overview dashboard

@cla-assistant
Copy link

cla-assistant bot commented Aug 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hifly81 hifly81 requested a review from Schm1tz1 August 6, 2023 09:42
@Schm1tz1
Copy link
Member

Schm1tz1 commented Aug 7, 2023

@hifly81 - I think we want to merge this into main, not 7.2-post, right? I guess that's still related to the default branch setting for this repo.

@Schm1tz1 Schm1tz1 changed the base branch from 7.2-post to main August 7, 2023 07:57
@Schm1tz1
Copy link
Member

Schm1tz1 commented Aug 7, 2023

Changed to main - what do you think?

@hifly81
Copy link
Contributor

hifly81 commented Aug 7, 2023

Changed to main - what do you think?

yes

Copy link
Member

@Schm1tz1 Schm1tz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schm1tz1
Copy link
Member

@Hanxnow77 - please sign the CLA. We need you to agree to it to merge the PR. Thanks!

@Schm1tz1 Schm1tz1 requested a review from hifly81 August 10, 2023 06:28
Copy link
Contributor

@hifly81 hifly81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schm1tz1 Schm1tz1 enabled auto-merge (squash) August 10, 2023 13:29
@Schm1tz1
Copy link
Member

Still some conflicts we need to merge manually. Maybe I can take a look tomorrow...

@hifly81
Copy link
Contributor

hifly81 commented Jan 10, 2024

@Hanxnow77 I can't approve it if you dont sign the CLA agreement

@Schm1tz1
Copy link
Member

Schm1tz1 commented Feb 2, 2024

@Hanxnow77 - it's really important for us that you approve the CLA so we finally can merge your request. Please take a look and click sign if you agree, otherwise we unfortunately have to close this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants