-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to ducktape #413
base: master
Are you sure you want to change the base?
Conversation
imcdo
commented
Jun 26, 2024
- Start to type objects in ducktape and give it annotations and make it a bit easier to work with.
- Update Paramiko
- Use ruff for formatting and style checking.
|
Very supportive of adding type annotations and official formatting. Are you planning to merge this PR?
My understanding is that |
@dotnwat id be happy to merge it, though i need a review and will need a sanity check. Black rules are compatible with ruff |
@imcdo perhaps we could merge the |
@dotnwat that would basicly require redoing the work and i dont have any bandwith right now, though I invite anyone who is interested in doing this. |
@imcdo even something simple would be helpful:
will produce two commits. the first is 1500+ LOC that can be ignored as reformatting. the second is half the size of this PR, and is much easier to inspect. |
🎉 All Contributor License Agreements have been signed. Ready to merge. |