test: Add checkout kbs helper script #2105
Conversation
|
@mkulke - based on @wainersm's suggestion to do the KBS checkout in a nicer way I've created this PR. I was going to wait for your caching PR to be merged first, as there is some code overlap, but I figured that you might find it useful to have the some of the changes centralised and moved out of the workflow, so they can be updated easier and tested without the |
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| TEST_DIR=$(cd "$(dirname "$(realpath "$0")")/../" || exit; pwd) |
There was a problem hiding this comment.
I'm not sure I understand this idiom. this is a subshell, so if we can't go into the folder we exit from the subshell? don't we want to abort with an error if any of those operations fail (i.e. set -euo pipefail` at the top)?
There was a problem hiding this comment.
Yeah sorry - shellcheck was nagging me about it and I probably added it without my brain engaged here. set -euo pipefail is the better approach, so I can remove a whole bunch of the || exit now. Thanks!
| popd || exit | ||
| popd || exit |
There was a problem hiding this comment.
I guess at the end of the script we don't have to popd. A bash script will run its own pwd.
makes sense, I don't mind rebasing |
stevenhorsman
force-pushed
the
rework-kbs-checkout
branch
2 times, most recently
from
1e5172d
to
c2f596a
Compare
We have duplicate code in multiple e2e workflows and manual doc instructions for checking out the KBS repo and switching to the correct branch. This both makes updating it prone to errors/omissions and means that if we make changes we can't test them in PRs due to the `pull_request_target` limitation, so split these out into a single script we can call from elsewhere. Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
rework-kbs-checkout
branch
from
c2f596a
to
d27be20
Compare
Add sudo to install and ensure it has execute permission
wainersm
merged commit 191ec51
into
confidential-containers:main
We have duplicate code in multiple e2e workflows
and manual doc instructions for checking out the KBS repo and switching to the correct branch. This both makes updating it prone to errors/omissions and means that if we make changes we can't test them in PRs due to the
pull_request_targetlimitation, so split these out into a single script we can call from elsewhere.