Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: podvm image: remove systemd tmpfiles setup delete #2043

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Docker: podvm image: remove systemd tmpfiles setup delete #2043

merged 1 commit into from
Sep 20, 2024

Conversation

stevenhorsman
Copy link
Member

Remove the systemd "systemd-tmpfiles-setup.service" -delete
and tidy up docs and code to remove missing features

@stevenhorsman
podvm: docker: Remove systemd-tmpfiles-setup delete
0bd0977 
We rely on the tempfiles directive to copy allow-all.rego
to `/run/peerpods/policy.rego`

Fixes: confidential-containers#2041

Signed-off-by: stevenhorsman <[email protected]>
@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Sep 18, 2024
mkulke
mkulke reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should untangle both aspects. One is a bug with the docker provider, the other issue is a regression that we should be able to fix in mkosi one way or the other, possibly with variables in the mkosi or docker builds

@stevenhorsman
Copy link
Member Author

I feel like we should untangle both aspects. One is a bug with the docker provider, the other issue is a regression that we should be able to fix in mkosi one way or the other, possibly with variables in the mkosi or docker builds

So are you proposing that I drop the second commit and ignore it completely, or move it to a different PR?

@stevenhorsman stevenhorsman force-pushed the docker-podvm-image-remove-systemd-tmpfiles-setup-delete branch from f5f12c2 to 0bd0977 Compare September 18, 2024 13:20
@mkulke
Copy link
Contributor

mkulke commented Sep 18, 2024

I feel like we should untangle both aspects. One is a bug with the docker provider, the other issue is a regression that we should be able to fix in mkosi one way or the other, possibly with variables in the mkosi or docker builds

So are you proposing that I drop the second commit and ignore it completely, or move it to a different PR?

I'd suggest to open an issue regarding the second issue. I suspect we want to keep the ability of specifying policies at build-time

@stevenhorsman
Copy link
Member Author

I'd suggest to open an issue regarding the second issue. I suspect we want to keep the ability of specifying policies at build-time

Done: #2045

bpradipt
bpradipt approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt
Copy link
Member

@stevenhorsman do we need the e2e libvirt test for this PR ?

@stevenhorsman
Copy link
Member Author

@stevenhorsman do we need the e2e libvirt test for this PR ?

Good point - this only impacts the docker provider, so I think we can ignore that

@bpradipt bpradipt removed the test_e2e_libvirt Run Libvirt e2e tests label Sep 20, 2024
@bpradipt
Copy link
Member

Merging this as e2 libvirt is not relevant for this PR.

@bpradipt bpradipt merged commit efadce3 into confidential-containers:main Sep 20, 2024
27 of 28 checks passed
@stevenhorsman stevenhorsman deleted the docker-podvm-image-remove-systemd-tmpfiles-setup-delete branch October 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenhorsman @mkulke @bpradipt