Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: Enhance s390x mkosi workflow #2019

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

workflows: Enhance s390x mkosi workflow #2019

wants to merge 18 commits into from

Commits on Sep 23, 2024

  1. workflows: podvm_mkosi: Remove s390x workflow 

    Now the alternative flow supports s390x, we can remove
the specific s390x flow

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    61e6001 View commit details
    Browse the repository at this point in the history

  2. workflows: make podvm_mkosi callable 

    So that the podvm_mkosi.yaml workflow can be reused in podvm.yaml
to build mkosi artifacts.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm @stevenhorsman
    wainersm authored and stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    08b9b17 View commit details
    Browse the repository at this point in the history

  3. workflows: podvm_mkosi: Multi-arch support 

    - Add inputs required to plug this into the e2e workflows
- Add parallel build on native s390x runner
- Add s390x mkosi install
- bump buildx setup action to newest version

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c6d12a4 View commit details
    Browse the repository at this point in the history

  4. podvm-mkosi: Update image targets 

    - Update image names to match the existing naming scheme
- Add debug suffix to the container image name for clarity
- Add push/load switch based on the PUSH env

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d34b408 View commit details
    Browse the repository at this point in the history

  5. podvm: docker provider: Rename Dockerfile 

    - Rename the docker provider's podvm Dockerfile
to Dockerfile.podvm_docker_provider for more clarity and to enable us
to use Dockerfile.podvm for the "main" version of the podvm in future
- Add arch awareness, so we can build images for multiple architectures.

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    344db21 View commit details
    Browse the repository at this point in the history

  6. workflows: Add podvm-mkosi workflow triggers 

    - Add calls to build the podvm-mkosi image
in the same places we build the current podvm image

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    082d219 View commit details
    Browse the repository at this point in the history

  7. podvm-mkosi: Try and fix permissions issues 

    Now we switched to docker buildx we are seeing permissions
problems in the s390x workflow

Signed-off-by: Hyounggyu Choi <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c8c0a7c View commit details
    Browse the repository at this point in the history

  8. workflows: podvm_mkosi: Add debug input 

    - Add input option to select between the debug and non-debug mkosi image build
- Initially use the debug build for e2e tests and non-debug for
release and image publish

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    acce770 View commit details
    Browse the repository at this point in the history

  9. workflows: build podvm-docker-fedora-image in podvm_mkosi 

    - Re-use the resources/binaries-tree binaries already fetched in
the podvm_mkosi.yaml to build the podvm image for the docker provider.
- We also need to clean up the image build artifacts to stop the
runner going out of space

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Signed-off-by: stevenhorsman <[email protected]>
    @wainersm @stevenhorsman
    wainersm authored and stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3d5ebb9 View commit details
    Browse the repository at this point in the history

  10. workflows: add test e2e workflow for docker 

    Add a callable workflow that run the e2e tests for the docker provider. This
workflow is similar to e2e_libvirt.yaml.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Signed-off-by: stevenhorsman <[email protected]>
    @wainersm @stevenhorsman
    wainersm authored and stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9354765 View commit details
    Browse the repository at this point in the history

  11. workflows: enable docker e2e test in e2e_run_all 

    This will make the e2e tests for docker to run. Initially it's disabled
on pull requests, so only running with the nightly and manual triggers.

Notice that's set continue-on-error so that the e2e_run_all workflow
exit status won't change, i.e. any failure on e2e_docker is disregarded.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm @stevenhorsman
    wainersm authored and stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    eaf23f3 View commit details
    Browse the repository at this point in the history

  12. workflows: Run libvirt e2e tests on all images 

    - Make the libvirt e2e test run against the podvm images for
both ubuntu and fedora OSes (for packer and mkosi respectively)
and both x86 and S390x runners
- Export `IBM_SE_CREDS_DIR` variable that is needed for KBS
deployment on s390x. For a non-TEE, this can just be a dummy
directory

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c1ce002 View commit details
    Browse the repository at this point in the history

  13. podvm_binaries: Add fedora cross-build support 

    Add fedora-like OS support for cross-build-extras

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fb0efbb View commit details
    Browse the repository at this point in the history

  14. workflows: podvm_mkosi: upload x86 qcow2 

    - Convert the mkosi image to a qcow2 file
and upload it to the docker registry, so we
can use it for libvirt testing
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4b0cfef View commit details
    Browse the repository at this point in the history

  15. podvm-mkosi: Try fedora 40 base for docker provider 

    F39 was given repo connection errors, so try bumping
to F40 to see if that helps

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9a59f6e View commit details
    Browse the repository at this point in the history

  16. podvm: Update platform logic in download-image 

    - It used to be that the fedora se image was the only
image that was built on s390x, but now with the other
mkosi builds, it feels better to make the s390x ubuntu
podvm image which is arguably set-up incorrectly the
special case. When we drop packer support we can
remove this code.

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4d3b593 View commit details
    Browse the repository at this point in the history

  17. workflow: libvirt e2e: cluster clean-up 

    Clean up the cluster after testing, so that we can tolerate
running on self-managed clusters that aren't thrown
away after each run
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e79b5c3 View commit details
    Browse the repository at this point in the history

  18. workflow: tests/e2e: Add KBS to debug 

    Add KBS installation info to the debug in case of failure

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e12d7b4 View commit details
    Browse the repository at this point in the history