-
Notifications
You must be signed in to change notification settings - Fork 1
Add more validation methods #5
base: main
Are you sure you want to change the base?
Conversation
rafaelbreno
commented
Feb 24, 2021
- regex
- in_array
I'll be looking forward to add more validation methods, all with tests, there's a huge list of validations that don't need DB connection(while we wait for Generics to develop Eloquent-ish ORM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Co-authored-by: Reindert <[email protected]>
Co-authored-by: Reindert <[email protected]>
Co-authored-by: Reindert <[email protected]>
Co-authored-by: Reindert <[email protected]>
Co-authored-by: Reindert <[email protected]>
Good job! I think method name I still have doubts about method name What are your thoughts on this? For the rest, I think it's perfect! Do you write the documentation, or should I do that? |
Totally agree with you, the naming changes, I'm gonna update, test and commit it, and let me write the documentation for it, would be nice to have participation on the whole process. |
Perfect 👍. You can choose whether In or Array is better |
Switched from "InArray()" to "Array()" because there's already a validation method called "In".
|
@rafaelbreno Have you succeeded in writing documentation yet? You have to say it if I can help you. |