Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: worker issues with Orkes Conductor API & other issues #123

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Dec 4, 2024

Changes in this PR

  • Fix: workers don't work with Orkes Conductor API due to deserialization error when polling. Orkes Conductor may return a Task with workflowTask.name == null and workflowTask.taskReferenceName == null.
  • Moved example workers to csharp-examples project. These examples were included in the sdk assembly file. This causes these workers to be discovered and started up (even if we don't want to).
  • Fix environmentResourceApi.GetAll() - Expected response type was wrong.
  • Increased sleeps and timeouts in tests to avoid The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.OperationCanceledException: The operation was canceled.
  • Allow a custom configuration in ApiExtensions. Lazily initialize from Environment variables if no custom config.
  • Improve unset Environment variable error message.

@jmigueprieto jmigueprieto self-assigned this Dec 4, 2024
@jmigueprieto jmigueprieto force-pushed the fix/broken-workers-and-other-fixes branch from 885f048 to ac3bf26 Compare December 4, 2024 14:37
@jmigueprieto jmigueprieto requested review from manan164, v1r3n, c4lm and a team December 4, 2024 21:48
@jmigueprieto jmigueprieto changed the title (WIP) FIX: worker issues with Orkes Conductor API and others FIX: worker issues with Orkes Conductor API & other issues Dec 4, 2024
- Lazily initialize from Environment variables if no custom config
- Improve unset env variable error message
@jmigueprieto jmigueprieto merged commit eba0c7f into main Dec 6, 2024
2 checks passed
@jmigueprieto jmigueprieto deleted the fix/broken-workers-and-other-fixes branch December 6, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants