Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed implementation for #515: Install development dependencies incrementally #516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nealstewart
Copy link

@nealstewart nealstewart commented Sep 28, 2023

Description

See [issue 515](#515 for background on why this was implemented.

I have implemented this as an optional --update flag to be based to conda-lock install.

This allows for the following use-case, which will support staged Docker builds, e.g. for light-weight testing images:

conda-lock install
conda-lock install --dev --update

I've copied the existing test and there's some potential for deduplication, but I've gone for simplicity. More than happy to refactor the two highly-coupled tests a bit.

@nealstewart nealstewart requested a review from a team as a code owner September 28, 2023 14:18
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 2d60143
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65169864a65f330007ad302f
😎 Deploy Preview https://deploy-preview-516--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb
Copy link
Contributor

maresb commented Sep 29, 2023

This is exciting! Looks fairly straightforward too. Could you please look into and fix these test failures?

I'm a bit overloaded at the moment, so no promises on timelines for getting this merged, but I'm hoping it will be easy once the CI is green.

@nealstewart nealstewart force-pushed the add-update-to-conda-lock-install branch from a3b61a5 to 2d60143 Compare September 29, 2023 09:26
@sjdemartini
Copy link

sjdemartini commented Apr 16, 2024

I'd love to see this change land—it would be super useful to be able to update an existing env to match a lockfile, rather than deleting/recreating the env as seems to happen now. The latter approach is unsafe for any shared environments (e.g. a JupyterHub kernel env), but conda-lock would be very useful there for updating environments predictably.

Neal, any chance you plan to come back to this and get CI to pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants