Update ruff config & CODEOWNERS
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-dot-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hm actually it looks like specifying CODEOWNERS as: conda-dot-org/.github/CODEOWNERS Lines 3 to 4 in e5d8ab8 means the latter overwrites the former, so it isn't even an AND operation: 
|
jezdez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found while working on #213 that as
CODEOWNERSis currently defined we are required to have approvals from both @conda/conda-dot-org AND @conda/communications teams. We actually want it to be one OR the other.Also correcting
pyproject.toml's ruff config based on my IDE lints.learn/orcommunity/, I have added it to the corresponding_sidebar.jsonfile.