Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid extra isfile() call in sha256_checksum #5422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

avoid extra isfile() call in sha256_checksum #5422

wants to merge 1 commit into from

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Jul 22, 2024

Description

Avoid calling isfile() twice on same filename in rapid succession

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@dholth dholth requested a review from a team as a code owner July 22, 2024 20:07
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 22, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #5422 will not alter performance

Comparing redundant-isfile (74b09fa) with main (9480525)

Summary

✅ 3 untouched benchmarks

@jaimergp
Copy link
Contributor

Needs a news file 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dholth @jaimergp @conda-bot