Use lazy Index in conda-build
#5363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5363 will not alter performanceComparing Summary
|
jaimergp
reviewed
Jul 31, 2024
Comment on lines
+134
to
+135
| "ignore:conda.core.index._supplement_index_with_system is pending deprecation:PendingDeprecationWarning:conda", | ||
| "ignore:conda.core.index._make_virtual_package is pending deprecation:PendingDeprecationWarning:conda", |
There was a problem hiding this comment.
We should fix these warnings instead of ignoring them, I'd say.
There was a problem hiding this comment.
Well, yes, but these come from conda-libmamba-solver, so I judged that fix outside the scope of this PR.
Of course we can make the fix in a branch there and use that development version here as well.
jaimergp
reviewed
Jul 31, 2024
| @@ -6,7 +6,7 @@ | |||
| from os.path import dirname | |||
|
|
|||
| from conda.base.context import context | |||
| from conda.core.index import get_index | |||
| from conda.core.index import Index | |||
There was a problem hiding this comment.
In principle, we won't need this during the deprecation period, right? So we can release a new conda without this PR and it should work, correct?
|
Hm. Seems I cannot reopen this PR. Too many times? I'll try if commenting fixes that and otherwise open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?