Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid undefined jinja errors for skipped recipes #5458

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

msarahan
Copy link
Contributor

Description

A few NVIDIA feedstocks on conda-forge have been failing to re-render lately. See conda-forge/cuda-nvdisasm-feedstock#12. The expected behavior was that undefined jinja variables shouldn't error out when the metadata is skipped.

I tracked it back to #5371, which I think is a good code improvement. In order to avoid these irrelevant errors for skipped recipes, we just abort after the first parsing pass.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@msarahan msarahan requested a review from a team as a code owner August 13, 2024 22:17
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 13, 2024
Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #5458 will not alter performance

Comparing msarahan:exit-render-early-on-skip (b8367cf) with main (f702c3a)

Summary

✅ 3 untouched benchmarks

@jakirkham
Copy link
Member

Thanks Michael! 🙏

If it is helpful, here is a generic example ( conda-forge/conda-smithy#2011 )

@jakirkham
Copy link
Member

Thanks Michael! 🙏

Looks like this is passes

Canary builds fail, but those are pointing out deprecations in other tests. Think we can safely ignore those here

jakirkham
jakirkham previously approved these changes Aug 14, 2024
@jakirkham
Copy link
Member

@kenodegard could you please take a look as well? 🙂

@kenodegard
Copy link
Contributor

The tests are blocked by conda/conda#14169

@jakirkham
Copy link
Member

Thanks Bianca and Ken! 🙏

jaimergp added a commit to conda-forge/staged-recipes that referenced this pull request Aug 29, 2024
@kenodegard
Copy link
Contributor

macOS tests are failing due to #5470

@beeankha beeankha added this to the 24.9.x milestone Sep 4, 2024
@kenodegard kenodegard merged commit 23c5797 into conda:main Sep 4, 2024
28 checks passed
@msarahan msarahan deleted the exit-render-early-on-skip branch September 9, 2024 16:33
@msarahan
Copy link
Contributor Author

msarahan commented Sep 9, 2024

Thanks for sticking with this through the slog, @beeankha and @kenodegard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants