Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport run_exports #20

Merged
merged 4 commits into from
Aug 16, 2024
Merged

backport run_exports #20

merged 4 commits into from
Aug 16, 2024

Conversation

billysuh7
Copy link

@billysuh7 billysuh7 commented Aug 14, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #14

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cupti-feedstock/actions/runs/10394662741.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7
Copy link
Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cupti-feedstock/actions/runs/10395072580.

@billysuh7
Copy link
Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cupti-feedstock/actions/runs/10395635960.

@jakirkham
Copy link
Member

Thanks Billy! 🙏

The re-rendering issues are the same ones we discussed recently ( conda-forge/conda-smithy#2011 ). Michael started an upstream fix PR ( conda/conda-build#5458 )

For now, would just do this locally using conda-build version 24.5 (any patch release should be fine)

Also in terms of CUDA 12.0, it looks like we updated to CUDA 12.1 in PR ( #4 ). The commit right before that appears to be commit ( d1f990e ). Would it be alright if we use that as the starting point for the v12.0 branch?

@jakirkham jakirkham changed the base branch from v12.0-previous to v12.0 August 15, 2024 02:17
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cupti-feedstock/actions/runs/10397700689.

@jakirkham
Copy link
Member

Also in terms of CUDA 12.0, it looks like we updated to CUDA 12.1 in PR ( #4 ). The commit right before that appears to be commit ( d1f990e ). Would it be alright if we use that as the starting point for the v12.0 branch?

Went ahead and made this change. Took the following steps:

  1. Renamed the conda-forge branch v12.0 to v12.0-previous
  2. GitHub automatically reflected that in this PR
  3. Created a new v12.0 branch at commit: d1f990e
  4. Retargeted this PR to the new v12.0 branch
  5. Deleted the v12.0-previous branch

As the new v12.0 branch is merely a few commits ahead of the old one, it should be possible to fast-forward merge local v12.0 branches

This PR had a few commits that are now considered included in v12.0 ( namely those from the long since merged PR: #4 ). After the change above this PR only shows the new changes that are not in v12.0. So after these changes this PR needs no updates

So this comment is merely informative. No action needed

@jakirkham
Copy link
Member

It looks like Travis CI is failing on linux_ppc64le. Unfortunately this is a known issue that extends beyond this feedstock or conda-forge. For more context, please see issue: conda-forge/status#185

As to resolving this, we had done some work in PR ( #12 ) to switch to cross-compilation-based builds. Think we should backport that as well to fix CI

The {{ stdlib("c") }} issue mentioned by the linter above ( #20 (comment) ) was fixed in PR: #13

So in short, think we should be backporting these 3 PRs here:

This should fix the CI issues and apply run_exports

Switch to cross-compilation for linux_aarch64 and linux_ppc64le conda-forge#12
=> to work around Travis CI linux-ppc64le job failing (conda-forge/status#185)

Migrate to {{ stdlib("c") }} conda-forge#13
=> use cos7 for all linux platforms (in os_version: of conda-forge.yml)
@billysuh7
Copy link
Author

@jakirkham thanks a million for all your help!

@billysuh7 billysuh7 marked this pull request as ready for review August 15, 2024 04:24
@jakirkham
Copy link
Member

Happy to help Billy! Also thank you for working on this 🙏

Let's see what Alex thinks 🙂

@billysuh7 billysuh7 merged commit 3297fed into conda-forge:v12.0 Aug 16, 2024
6 checks passed
@jakirkham
Copy link
Member

Thanks Billy and Alex! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants