Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker build tasks #1001

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Remove docker build tasks #1001

wants to merge 6 commits into from
+14 −200

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 25, 2024 •
edited
Loading

Fixes #941

Description

This PR removes actions for building docker images and related functionality, including:

  • removing the action action_generate_conda_docker
  • removing docker artifacts from the list of artifacts generated by default
  • remove docker artifacts from artifact queries
  • deprecate the api endpoint /build/<build id>/docker
    • this endpoint will continue to work, but will have an added header deprecation: true

We'll leave in the docker registry functionality. This requires the following docker related bits to stay

  • the DOCKER_ build artifact types
  • all docker db related items

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 5a9c53e
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6744ec29af7474000864d389

@soapy1 soapy1 added area: api area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit b9fe1d9
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67451fb94c7864000823fc0e

@soapy1
Deprecate api endpoint /build/<build id>/docker
d9a4a66 
rfc https://datatracker.ietf.org/doc/html/draft-ietf-httpapi-deprecation-header
suggests using a "Deprecation" header in the response with the
intended deprecation date. We don't have a specific date, so we'll
set the value of this header to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: api area: user experience 👩🏻‍💻 Items impacting the end-user experience
Projects
conda-store 🐍
Status: New 🚦
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove docker related build tasks
1 participant
@soapy1