Rebuild for numpy 2.0 #94

regro-cf-autotick-bot · 2024-06-27T04:26:56Z

This PR has been triggered in an effort to update numpy2.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

Here are some more details about this specific migrator:

TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
PR has updated the recipe to account for the changes (see below for details).

The biggest change is that we no longer need to use the oldest available numpy
version at build time in order to support old numpy version at runtime - numpy
will by default use a compatible ABI for the oldest still-supported numpy versions.

Additionally, we no longer need to use {{ pin_compatible("numpy") }} as a
run requirement - this has been handled for more than two years now by a
run-export on the numpy package itself. The migrator will therefore remove
any occurrences of this.

However, by default, building against numpy 2.0 will assume that the package
is compatible with numpy 2.0, which is not necessarily the case. You should
check that the upstream package explicitly supports numpy 2.0, otherwise you
need to add a - numpy <2.0dev0 run requirement until that happens (check numpy
issue 26191 for an overview of the most important packages).

To-Dos:

Match run-requirements for numpy (i.e. check upstream pyproject.toml or however the project specifies numpy compatibility)

If upstream is not yet compatible with numpy 2.0, add numpy <2.0dev0 upper bound under run:.

If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases.

If upstream requires a minimum numpy version newer than 1.19, you can add numpy >=x.y under run:.

Remove any remaining occurrences of {{ pin_compatible("numpy") }} that the bot may have missed.

PS. If the build does not compile anymore, this is almost certainly a sign that
the upstream project is not yet ready for numpy 2.0; do not close this PR until
a version compatible with numpy 2.0 has been released upstream and on this
feedstock (in the meantime, you can keep the bot from reopening this PR in
case of git conflicts by marking it as a draft).

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.}

TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot PR has updated the recipe to account for the changes (see below for details). The biggest change is that we no longer need to use the oldest available numpy version at build time in order to support old numpy version at runtime - numpy will by default use a compatible ABI for the oldest still-supported numpy versions. Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a run requirement - this has been handled for more than two years now by a run-export on the numpy package itself. The migrator will therefore remove any occurrences of this. However, by default, building against numpy 2.0 will assume that the package is compatible with numpy 2.0, which is not necessarily the case. You should check that the upstream package explicitly supports numpy 2.0, otherwise you need to add a `- numpy <2.0dev0` run requirement until that happens (check numpy issue 26191 for an overview of the most important packages). ### To-Dos: * [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility) * If upstream is not yet compatible with numpy 2.0, add `numpy <2.0dev0` upper bound under `run:`. * If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases. * If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`. * [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed. PS. If the build does not compile anymore, this is almost certainly a sign that the upstream project is not yet ready for numpy 2.0; do not close this PR until a version compatible with numpy 2.0 has been released upstream and on this feedstock (in the meantime, you can keep the bot from reopening this PR in case of git conflicts by marking it as a draft).

…nda-forge-pinning 2024.06.27.03.50.52

conda-forge-webservices · 2024-06-27T04:27:02Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Needed for NumPy 2.0 support. xref: pybind/pybind11@705efcc

jakirkham · 2024-06-27T08:55:13Z

@conda-forge-admin , please re-render

github-actions · 2024-06-27T08:56:40Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xtensor-python-feedstock/actions/runs/9693637278.

jakirkham

Noted some changes to the pybind11 constraints to ensure that when building for NumPy 2, pybind11 version 2.12.0 or newer is used. Previous versions of pybind11 are incompatible with NumPy 2. So pybind11 needs to be 2.12.0 at least

xref: pybind/pybind11#5009

jakirkham · 2024-06-27T09:01:36Z

recipe/meta.yaml

    - cmake
    - make                                   # [unix]
  host:
    - python
    - xtl >=0.7,<0.8
    - xtensor >=0.25.0,<0.26
-    - pybind11 >=2.6.1,<3
+    - pybind11 >=2.12.0,<3


This is done to make sure a NumPy 2 compatible pybind11 version is used (so 2.12.0+)

jakirkham · 2024-06-27T09:02:22Z

recipe/meta.yaml

@@ -21,7 +21,7 @@ requirements:
    - python                                 # [build_platform != target_platform]
    - cross-python_{{ target_platform }}     # [build_platform != target_platform]
    - numpy                                  # [build_platform != target_platform]
-    - pybind11                               # [build_platform != target_platform]
+    - pybind11 >=2.12.0,<3                   # [build_platform != target_platform]


Also applied the same constraint in requirements/build as it was unconstrained previously

jakirkham · 2024-06-27T09:06:02Z

Based on this upstream discussion ( xtensor-stack/xtensor-python#308 ), it sounds like xtensor-python may already be compatible with NumPy 2 (thanks to use of pybind11)

Made a couple light tweaks above to make sure that a new enough pybind11 is used with NumPy 2 builds

Maybe someone from @conda-forge/xtensor-python could look this over? 🙂

jakirkham · 2024-06-27T11:05:22Z

@conda-forge-admin , please re-render

github-actions · 2024-06-27T11:06:47Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xtensor-python-feedstock/actions/runs/9695438073.

SylvainCorlay · 2024-08-06T12:38:14Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.08.05.15.28.08

conda-forge-webservices · 2024-08-06T12:39:41Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

SylvainCorlay · 2024-08-06T13:23:37Z

Thanks for working on this @jakirkham !

jakirkham · 2024-08-06T17:24:48Z

Thanks Sylvain! 🙏

regro-cf-autotick-bot added 2 commits June 27, 2024 04:24

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.2, and co…

1a44579

…nda-forge-pinning 2024.06.27.03.50.52

regro-cf-autotick-bot requested review from JohanMabille and SylvainCorlay as code owners June 27, 2024 04:26

jakirkham added 3 commits June 27, 2024 01:52

Bump pybind11 min to 2.12.0

1f267ba

Needed for NumPy 2.0 support. xref: pybind/pybind11@705efcc

Double quote compiler arg too

1a12d53

Also constrain pybind11 in requirements/build

904d0ac

jakirkham reviewed Jun 27, 2024

View reviewed changes

Refresh Python 3.12 migrator

099978e

MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.37.2, and co…

ba1b4fc

…nda-forge-pinning 2024.08.05.15.28.08

SylvainCorlay merged commit 8f310a3 into conda-forge:main Aug 6, 2024
22 checks passed

regro-cf-autotick-bot deleted the rebuild-numpy2-0-1_h3a7d21 branch August 6, 2024 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for numpy 2.0 #94

Rebuild for numpy 2.0 #94

regro-cf-autotick-bot commented Jun 27, 2024

conda-forge-webservices bot commented Jun 27, 2024

jakirkham commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

jakirkham left a comment

jakirkham Jun 27, 2024

jakirkham Jun 27, 2024

jakirkham commented Jun 27, 2024

jakirkham commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

SylvainCorlay commented Aug 6, 2024

conda-forge-webservices bot commented Aug 6, 2024

SylvainCorlay commented Aug 6, 2024

jakirkham commented Aug 6, 2024

Rebuild for numpy 2.0 #94

Rebuild for numpy 2.0 #94

Conversation

regro-cf-autotick-bot commented Jun 27, 2024

To-Dos:

conda-forge-webservices bot commented Jun 27, 2024

jakirkham commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

jakirkham left a comment

Choose a reason for hiding this comment

jakirkham Jun 27, 2024

Choose a reason for hiding this comment

jakirkham Jun 27, 2024

Choose a reason for hiding this comment

jakirkham commented Jun 27, 2024

jakirkham commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

SylvainCorlay commented Aug 6, 2024

conda-forge-webservices bot commented Aug 6, 2024

SylvainCorlay commented Aug 6, 2024

jakirkham commented Aug 6, 2024