Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile tk on mac without the aqua option #48

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

smithsp
Copy link
Contributor

@smithsp smithsp commented Apr 21, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR is a work in progress. I assume that the conda-forge tk admins don't want to always disable aqua on mac, and I am trying to take what @dsentinel started in https://github.com/dsentinel/tk-feedstock/commits/mac_noaqua to see if that compiles, and then work to implement a noaqua variant that makes the desired changes.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@smithsp smithsp changed the title WIP: Compile tk on mac without the aqua option Compile tk on mac without the aqua option Apr 22, 2021
@smithsp
Copy link
Contributor Author

smithsp commented Apr 22, 2021

@conda-forge/tk
I believe that this is ready for review. One problem that is outstanding is that I only want a noaqua variant to be built on osx, for which I added a selector in the conda_build_config.yaml file, but then the linux rendering of the meta.yaml fails, because apparently my variant tk_aqua has no value. That seems like a bug in conda to not allow a single value variant or in jinja to not allow the setting of the tk_aqua variable with the line {% set tk_aqua = tk_aqua or 'aqua' %}.

@smithsp
Copy link
Contributor Author

smithsp commented Apr 22, 2021

@conda-forge-admin, please rerender

@smithsp
Copy link
Contributor Author

smithsp commented May 3, 2021

@conda-forge/tk Ping

@smithsp
Copy link
Contributor Author

smithsp commented May 20, 2021

@conda-forge-admin, please rerender

@dsentinel
Copy link

Thanks for this. This timing is great, as our workarounds are getting more cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants