Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diffpy.srmise #27777

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Oct 4, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 4, 2024

@sbillinge

Could you please write a comment here (as instructed) that you would be willing to be listed there as a maintainer?

Copy link

github-actions bot commented Oct 4, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/diffpy.srmise/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: sbillinge. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srmise/meta.yaml) and found it was in an excellent condition.

@sbillinge
Copy link
Contributor

@sbillinge

Could you please write a comment here (as instructed) that you would be willing to be listed there as a maintainer?

I am willing to be a maintainer on this project

Copy link

github-actions bot commented Oct 5, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 5, 2024

@conda-forge/help-python, ready for review!

For windows, we are encountering an error message, which appears to be related to dynamic versioning. I checked that the version is correctly parsed from our GitHub's release tags.


    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\build_meta.py", line 318, in run_setup
      exec(code, locals())
    File "<string>", line 1, in <module>
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\__init__.py", line 117, in setup
      return distutils.core.setup(**attrs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\_distutils\core.py", line 145, in setup
      _setup_distribution = dist = klass(attrs)
                                   ^^^^^^^^^^^^
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\dist.py", line 283, in __init__
      _Distribution.__init__(self, dist_attrs)
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\_distutils\dist.py", line 279, in __init__
      self.finalize_options()
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools\dist.py", line 635, in finalize_options
      ep(self)
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools_git_versioning.py", line 256, in infer_version
      version = version_from_git(dist.metadata.name, **config, root=root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\site-packages\setuptools_git_versioning.py", line 494, in version_from_git
      lines = pkg_info.read_text().splitlines()
              ^^^^^^^^^^^^^^^^^^^^
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\pathlib.py", line 1028, in read_text
      return f.read()
             ^^^^^^^^
    File "C:\bld\diffpy.srmise_1728095290645\_h_env\Lib\encodings\cp1252.py", line 23, in decode
      return codecs.charmap_decode(input,self.errors,decoding_table)[0]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 5499: character maps to <undefined>
  [end of output]

This error did not occur for one of the other package that was recently merged to conda-forge a few days ago: #27265 Could you please help?

@synapticarbors
Copy link
Member

It looks like there is a bad character in the README.rst that the os encoding in windows doesn't like:

with open('README.rst', encoding='cp1252') as f:
    data = f.read()

I'm having trouble finding the exact location, but maybe you can spot it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants