Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diffpy.labpdfproc #27776

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Oct 4, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

github-actions bot commented Oct 4, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/diffpy.labpdfproc/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: yucongalicechen. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.labpdfproc/meta.yaml) and found some lint.

Here's what I've got...

For recipes/diffpy.labpdfproc/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 4, 2024

@sbillinge @yucongalicechen

Could you please write a comment here (as instructed) that you would be willing to be listed there as a maintainer?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.labpdfproc/meta.yaml) and found it was in an excellent condition.

@sbillinge
Copy link
Contributor

I am willing to be a maintainer on this project

@yucongalicechen
Copy link

I am willing to be listed as a maintainer.

Copy link

github-actions bot commented Oct 4, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants