-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skyrim and dependencies #27273
base: main
Are you sure you want to change the base?
Add skyrim and dependencies #27273
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/earth2mip/meta.yaml:
For recipes/skyrim/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/earth2mip/meta.yaml:
For recipes/skyrim/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/earth2mip/meta.yaml:
For recipes/skyrim/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/dali/meta.yaml:
For recipes/earth2mip/meta.yaml:
For recipes/nvidia-modulus/meta.yaml:
For recipes/skyrim/meta.yaml:
For recipes/torch-harmonics/meta.yaml:
For recipes/torch-harmonics/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/earth2mip/meta.yaml:
For recipes/nvidia-dali-python/meta.yaml:
For recipes/nvidia-modulus/meta.yaml:
For recipes/skyrim/meta.yaml:
For recipes/torch-harmonics/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/earth2mip/meta.yaml:
For recipes/nvidia-dali-python/meta.yaml:
For recipes/nvidia-modulus/meta.yaml:
For recipes/skyrim/meta.yaml:
For recipes/torch-harmonics/meta.yaml:
|
agreed |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/earth2mip/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@beckermr, the linter fails here |
fixed! thanks for the bug report! |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge/help-python, this is ready. All the recipes are noarch and therefore only linux-64 needs to pass. (Some deps are linux-64 only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small clarification request regarding entrypoints. Otherwise looks good to me.
recipes/earth2mip/meta.yaml
Outdated
entry_points: | ||
- fcn = earth2mip.networks.fcn:load | ||
- dlwp = earth2mip.networks.dlwp:load | ||
- pangu = earth2mip.networks.pangu:load | ||
- pangu_6 = earth2mip.networks.pangu:load_6 | ||
- pangu_24 = earth2mip.networks.pangu:load_24 | ||
- fcnv2_sm = earth2mip.networks.fcnv2_sm:load | ||
- graphcast = earth2mip.networks.graphcast:load_time_loop | ||
- graphcast_operational = earth2mip.networks.graphcast:load_time_loop_operational | ||
- graphcast_small = earth2mip.networks.graphcast:load_time_loop_small |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these are not script entry points, but rather plugin-type (see here). Do we still need to list them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. I didn't notice it. This was created by grayskull and I didn't look thoroughly. Will fix.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).