Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skyrim and dependencies #27273

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add skyrim and dependencies #27273

wants to merge 27 commits into from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 14, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/skyrim/meta.yaml) and found some lint.

Here's what I've got...

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/skyrim/meta.yaml:

  • The home item is expected in the about section.
  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/skyrim/meta.yaml) and found some lint.

Here's what I've got...

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/skyrim/meta.yaml:

  • The home item is expected in the about section.
  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/skyrim/meta.yaml) and found some lint.

Here's what I've got...

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/skyrim/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dali/meta.yaml, recipes/earth2mip/meta.yaml, recipes/nvidia-modulus/meta.yaml, recipes/skyrim/meta.yaml, recipes/torch-harmonics/meta.yaml) and found some lint.

Here's what I've got...

For recipes/dali/meta.yaml:

  • No valid build backend found for Python recipe for package nvidia-dali-python using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/nvidia-modulus/meta.yaml:

  • The home item is expected in the about section.
  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/skyrim/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/torch-harmonics/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/torch-harmonics/meta.yaml:

  • No valid build backend found for Python recipe for package torch-harmonics using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/nvidia-dali-python/meta.yaml, recipes/nvidia-modulus/meta.yaml, recipes/skyrim/meta.yaml, recipes/torch-harmonics/meta.yaml) and found some lint.

Here's what I've got...

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/nvidia-dali-python/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/nvidia-modulus/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/skyrim/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/torch-harmonics/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/ecmwflibs/meta.yaml, recipes/nvidia-dali-python/meta.yaml, recipes/nvidia-modulus/meta.yaml, recipes/skyrim/meta.yaml, recipes/torch-harmonics/meta.yaml) and found some lint.

Here's what I've got...

For recipes/earth2mip/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/nvidia-dali-python/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/nvidia-modulus/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/skyrim/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

For recipes/torch-harmonics/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: timkpaine. Please ask them to comment on this PR if they are.

@timkpaine
Copy link
Member

agreed

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/earth2mip/meta.yaml, recipes/ecmwflibs/meta.yaml, recipes/nvidia-dali-python/meta.yaml, recipes/nvidia-modulus/meta.yaml, recipes/skyrim/meta.yaml, recipes/torch-harmonics/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/earth2mip/meta.yaml:

  • Use importlib-metadata instead of importlib_metadata

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Sep 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-modulus/meta.yaml, recipes/skyrim/meta.yaml, recipes/earth2mip/meta.yaml) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Sep 18, 2024

@beckermr, the linter fails here

@beckermr
Copy link
Member

fixed! thanks for the bug report!

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@isuruf
Copy link
Member Author

isuruf commented Oct 2, 2024

@conda-forge/help-python, this is ready. All the recipes are noarch and therefore only linux-64 needs to pass. (Some deps are linux-64 only)

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small clarification request regarding entrypoints. Otherwise looks good to me.

Comment on lines 18 to 27
entry_points:
- fcn = earth2mip.networks.fcn:load
- dlwp = earth2mip.networks.dlwp:load
- pangu = earth2mip.networks.pangu:load
- pangu_6 = earth2mip.networks.pangu:load_6
- pangu_24 = earth2mip.networks.pangu:load_24
- fcnv2_sm = earth2mip.networks.fcnv2_sm:load
- graphcast = earth2mip.networks.graphcast:load_time_loop
- graphcast_operational = earth2mip.networks.graphcast:load_time_loop_operational
- graphcast_small = earth2mip.networks.graphcast:load_time_loop_small
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these are not script entry points, but rather plugin-type (see here). Do we still need to list them here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I didn't notice it. This was created by grayskull and I didn't look thoroughly. Will fix.

@isuruf isuruf requested a review from zklaus October 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants