-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cublasMp recipes #26580
Adding cublasMp recipes #26580
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cublasmp:
For recipes/libcal:
For recipes/libcublasmp:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cublasmp:
For recipes/libcal:
For recipes/libcublasmp:
|
cc @conda-forge/cuda |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cublasmp:
For recipes/libcal:
For recipes/libcublasmp:
|
The failures in osx and win are coming from the top level metapackage which is currently set to |
The cuda 11.8 build seems to be failing with:
I was getting the expected cuda packages for each version locally, so not sure if I need to tighten a constraint somewhere. |
My impression is that in staged recipes only CUDA 11 is supported, so CUDA 12 can wait until we have feedstocks. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: I wonder if it'd make things easier to make the cublasmp
meta package an output of libcublasmp-feedstock? (No strong opinion, just curious if this has been considered.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping them separate helps with how we setup releases internally. The recipes would be updated with a similar process to CUDA, just on a smaller scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you not want run_exports for this package? Otherwise, what is the purpose of this package? No downstream packages should depend on this pacakge directly because they would get all of the devlopement files for libcal and libcublasmp but none of the run_exports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question. What's the purpose of this package? Also, I don't see a compelling reason to keep this in a separate feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is for convenient installation of all components, similar to the cuda metapackages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add that this is not to be used in a conda-build context in the summary.
Also, please move this to libcublasmp recipe if there's not reason to keep this in a separate feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note now.
Having separate feedstocks helps us with maintenance by keeping the design consistent across products.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't make sense to me at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain in more detail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CUDA metapackages are in separate feedstocks, I'm not seeing a reason to change that for cublasmp. Versions of these packages are not technically coupled, they are given a release label as seen in https://developer.download.nvidia.com/compute/cublasmp/redist/redistrib_0.2.1.json
"release_label": "0.2.1",
"release_product": "cublasmp",
Co-authored-by: Marcin Rogowski <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
I am a bit confused by the log:
and
It seems as if the copy logic in top-level |
Co-authored-by: Leo Fang <[email protected]>
It seems to be working fine, except for the osx/win CIs which are known to fail in stage-recipes if there's a generic/noarch recipe. @conda-forge/staged-recipes this is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you not want run_exports for this package? Otherwise, what is the purpose of this package? No downstream packages should depend on this pacakge directly because they would get all of the devlopement files for libcal and libcublasmp but none of the run_exports.
@kvoronin @mrogowski could you address the questions? Thanks. |
I answered some of the questions. I hope @adibbley can answer the rest. Thanks! |
Co-authored-by: Marcin Rogowski <[email protected]>
Co-authored-by: Daniel Ching <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cublasmp/meta.yaml:
For recipes/libcal/meta.yaml:
For recipes/libcublasmp/meta.yaml:
|
@conda-forge/staged-recipes can someone please take another look? 🙂 |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
@conda-forge/help-c-cpp let's see if this works |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
This recipe is breaking staged recipes. It seems that the cuda compiler version variable in jinja2 needs a default definition. |
This was due to a since fixed conda-build bug Have added more info in comment: #27547 (comment) |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).This PR adds recipes for the NVIDIA Math Library cublasMp, which contains 2 library components: libcublasmp and libcal.