Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add espsim and resp #23732

Merged
merged 16 commits into from
Dec 18, 2023
Merged

add espsim and resp #23732

merged 16 commits into from
Dec 18, 2023

Conversation

hadim
Copy link
Member

@hadim hadim commented Aug 20, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/espsim, recipes/resp) and found some lint.

Here's what I've got...

For recipes/espsim:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/resp:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/espsim, recipes/resp) and found some lint.

Here's what I've got...

For recipes/resp:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/espsim, recipes/resp) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Aug 20, 2023

@loriab do you want to be a maintainer of the resp package?

@hadim
Copy link
Member Author

hadim commented Aug 20, 2023

@hesther do you want to be a maintainer of the espsim package?

recipes/espsim/meta.yaml Outdated Show resolved Hide resolved
@hesther
Copy link

hesther commented Aug 20, 2023

Hi @hadim, would you or someone else also be a co-maintainer? I have never had a package on conda-forge, so might need a little startup time (but the conda-forge website seems to have sufficient detail to manage it, hopefully).

Also, I have just added a git tag hesther/espsim#29

@hadim
Copy link
Member Author

hadim commented Aug 20, 2023

Hi @hadim, would you or someone else also be a co-maintainer? I have never had a package on conda-forge, so might need a little startup time (but the conda-forge website seems to have sufficient detail to manage it, hopefully).

Yes I will be co-maintainer on both packages.

@hesther
Copy link

hesther commented Aug 20, 2023

Ok great, then happy to be a co-maintainer

@loriab
Copy link
Contributor

loriab commented Sep 10, 2023

Sure, I'd be glad to be a maintainer on resp, thanks. I'm trying to get it unblocked..

@loriab
Copy link
Contributor

loriab commented Dec 16, 2023

ok, you're unblocked: psi4 is using libint 2.8.0 from the main conda-forge channel.

@hadim
Copy link
Member Author

hadim commented Dec 16, 2023

Thanks @loriab for your work on this!

@hadim hadim marked this pull request as ready for review December 16, 2023 12:51
@hadim
Copy link
Member Author

hadim commented Dec 16, 2023

@conda-forge/help-python ready for review. thanks.

recipes/resp/meta.yaml Outdated Show resolved Hide resolved
@hadim
Copy link
Member Author

hadim commented Dec 16, 2023

LGTM

@ocefpaf ocefpaf merged commit f4f6540 into conda-forge:main Dec 18, 2023
5 checks passed
@hadim hadim deleted the espsim branch December 18, 2023 18:14
@hadim
Copy link
Member Author

hadim commented Dec 18, 2023

Thank you @ocefpaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants