Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ogre-next #19384

Merged
merged 7 commits into from
Jun 25, 2022
Merged

Add ogre-next #19384

merged 7 commits into from
Jun 25, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 24, 2022

This PR adds ogre-next, a C++ 3D graphics engine .

First of all, it is important to clarify a bit the relation between ogre and ogre-next. What is now ogre-next started as ogre 2, with substutiantial changes w.r.t. to ogre 1. However, many users of ogre never migrated to ogre 2, so they continued to use and mantain ogre 1. As a consequence, at some point ogre 2 renamed itself to ogre-next, while ogre 1 continued to exits as ogre, also bumping its major version number, going from 1.13 to 13 (see https://github.com/conda-forge/ogre-feedstock).

As a consequence, it is quite important to permit to ogre and ogre-next to be installed side-by-side in the same environment, as for example in the robotics world RViz2 (a visualizer) uses ogre, while the new generation of Gazebo (formerly known as Ignition) uses ogre-next . The upstream ogre-next still needs to complete its support to be installable side-by-side with ogre (see OGRECave/ogre-next#232), so in this PR we patched the project to be side-by-side installable with ogre as was done in Debian/Ubuntu packacing (see https://salsa.debian.org/ogre-team/ogre-next/-/blob/a27f70cd8c6b82e3fc207fefe557b43bc49634b4/debian/README.Debian).

For an overview of the existing differences between Ogre and Ogre Next, see https://www.ogre3d.org/about/what-version-to-choose .

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ogre-next) and found some lint.

Here's what I've got...

For recipes/ogre-next:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ogre-next) and found it was in an excellent condition.

@traversaro

This comment was marked as outdated.

@traversaro

This comment was marked as outdated.

@traversaro

This comment was marked as outdated.

@traversaro
Copy link
Contributor Author

Even if the CI is still finishing, osx_64 and win_64 were successful before, so I think the PR is ready for review. @conda-forge/help-c-cpp

@wolfv @Tobias-Fischer this is necessary to actually have a working Gazebo (formerly known as Ignition) packages with ROS2, as ROS2 RViz2 uses Ogre 1.12, and Gazebo does not work with Ogre 1.12 (see RoboStack/ros-galactic#104 for a problem generated by the fact that we do not have ogre-next). As you are mantainers of ogre feedstock, please reply if you like to be mantainers of ogre-next as well, thanks!

@Tobias-Fischer
Copy link
Contributor

I'll give this one a miss re becoming maintainer..

@wolfv
Copy link
Member

wolfv commented Jun 25, 2022

Thanks for working in this! I'm happy to be added as a maintainer.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ogre-next) and found some lint.

Here's what I've got...

For recipes/ogre-next:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ogre-next) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

Thanks for working in this! I'm happy to be added as a maintainer.

Done in b87742c .

@wolfv
Copy link
Member

wolfv commented Jun 25, 2022

Let me know if you think this is ready. Happy to merge!

@traversaro
Copy link
Contributor Author

traversaro commented Jun 25, 2022

The PR is ready.

@wolfv wolfv merged commit 5937ebd into conda-forge:main Jun 25, 2022
@traversaro
Copy link
Contributor Author

Thanks @wolfv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants