-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for mlrose python package #18102
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mlrose:
For recipes/mlrose:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin These builds are failing because a LICENSE file was not found. However, a LICENSE file is indeed present in the source's root directory. I would appreciate some assistance resolving this issue. |
requires: | ||
- pip | ||
commands: | ||
- pip check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python package still requires sklearn
instead of scikit-learn
. This is why the test is failing. Remove this check (and the requires pip).
The import will be enough.
run: | ||
- numpy | ||
- scipy | ||
- scikit-learn <0.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the package really need such an old version of scikit-learn
?
Fine if it's really the case, but you should open an issue upstream so it's updated to support newer versions.
It will be difficult to install with other packages otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found this PR and a comment that recommends to move to mlrose-hiive.
Seems like mlrose
isn't maintained anymore.
Might be better to submit a recipe for mlrose-hiive
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beenje I also found that to be the case. I'll be updating this to use mlrose-hiive.
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).