Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for mlrose python package #18102

Closed
wants to merge 4 commits into from

Conversation

onelharrison
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mlrose) and found some lint.

Here's what I've got...

For recipes/mlrose:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
  • requirements: host: python >= 3 should not contain a space between relational operator and the version, i.e. python >=3
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/mlrose:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mlrose) and found it was in an excellent condition.

@onelharrison
Copy link
Author

onelharrison commented Feb 19, 2022

@conda-forge-admin These builds are failing because a LICENSE file was not found. However, a LICENSE file is indeed present in the source's root directory. I would appreciate some assistance resolving this issue.

@beenje beenje self-requested a review February 19, 2022 16:21
recipes/mlrose/meta.yaml Outdated Show resolved Hide resolved
recipes/mlrose/meta.yaml Show resolved Hide resolved
requires:
- pip
commands:
- pip check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python package still requires sklearn instead of scikit-learn. This is why the test is failing. Remove this check (and the requires pip).
The import will be enough.

run:
- numpy
- scipy
- scikit-learn <0.21.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the package really need such an old version of scikit-learn?

Fine if it's really the case, but you should open an issue upstream so it's updated to support newer versions.
It will be difficult to install with other packages otherwise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found this PR and a comment that recommends to move to mlrose-hiive.

Seems like mlrose isn't maintained anymore.
Might be better to submit a recipe for mlrose-hiive?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beenje I also found that to be the case. I'll be updating this to use mlrose-hiive.

@stale
Copy link

stale bot commented Jul 30, 2022

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jul 30, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

3 participants