Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python 3.13 #91

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11452450229 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bdice
Copy link
Contributor

bdice commented Oct 28, 2024

@leofang May we merge this? CI is passing, just want to let you press the button in case you have any thoughts before merging.

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @bdice @jakirkham for bringing this to our (CUDA Python team) attention.

I wish the migrator has a bit richer information describing what's happening... (Our CUDA 12 migrator did a great job, for example.) There is no conda-forge news posting regarding PY313 migration, either, so it took me a while to understand that

  • this is only for PY313 "regular" build
  • there is a separate PY313t "free-threading" migrator but it's currently paused
    • it's still unclear to me how to expand the build the matrix to include py313t when the migration starts

All these searches/studies add up to the time needed to catch up with the latest situation for completing the review, since I've been detached a bit from the recent CF development 🥲

I am approving this migrator as a project developer, with the caveat that CF migrators sometimes can be ahead of the projects becoming prepared; that is, we haven't done any tests for PY313 support, so "use it at your own risk" 😅 (But please do report any issues so that we can fix it properly!)

@leofang
Copy link
Member

leofang commented Oct 31, 2024

@conda-forge-admin, please rerender

@leofang leofang added the automerge Merge the PR when CI passes label Oct 31, 2024
@github-actions github-actions bot merged commit c8da01f into conda-forge:main Oct 31, 2024
18 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@leofang leofang mentioned this pull request Oct 31, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python313-0-1_h0add5c branch October 31, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants