Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build to splayed layout #83

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Jun 26, 2024

Fixes #82
Closes #74
Closes NVIDIA/cuda-python#46

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham marked this pull request as draft June 26, 2024 18:07
@conda-forge-webservices

This comment was marked as resolved.

@jakirkham jakirkham force-pushed the conda_forge_admin_82 branch 2 times, most recently from 7983c59 to d469436 Compare June 26, 2024 18:46
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

jakirkham commented Jun 26, 2024

GitHub autogenerated artifacts fail to checksum as something changed in the autogeneration process again

Here is what we see on CI (attached log for posterity):

Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(execute())
  File "/opt/conda/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 590, in execute
    api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 250, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3638, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2419, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 762, in try_download
    source.provide(metadata)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 1035, in provide
    unpack(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 169, in unpack
    src_path, unhashed_fn = download_to_cache(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 125, in download_to_cache
    raise RuntimeError(
RuntimeError: SHA256 mismatch: 'eb6d1b2cd881de0c14963ddb9cb7f3ec5df1b31370133267678265e31fb743b2' != 'ee7e3df43da7d924207e03efa4d5e5466801510b3e1f0377d425c6e6a8d823bb'

Edit: Raising this upstream ( NVIDIA/cuda-python#71 )

@jakirkham jakirkham changed the title MNT: rerender Switch build to splayed layout Jun 26, 2024
@jakirkham jakirkham marked this pull request as ready for review June 26, 2024 19:33
@jakirkham
Copy link
Member

Think this is working as we can see lines like this on CI:

 Parsing headers in "['/home/conda/feedstock_root/build_artifacts/cuda-python_1719430415930/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/targets/x86_64-linux/include', '/home/conda/feedstock_root/build_artifacts/cuda-python_1719430415930/_build_env/targets/x86_64-linux/include']" (Caching False)

Copy link

@vzhurba01 vzhurba01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham jakirkham merged commit 915031a into conda-forge:main Jun 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure build for splayed layout Drop environment variable workarounds in build Splayed layout support
3 participants