-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: shorten grayskull usage by one step #2222
base: main
Are you sure you want to change the base?
Conversation
- It's more user friendly to provide ready to execute commands, e.g. an environment named `grayskull` makes sense if it's just `grayskull` that's installed there. - One can directly install grayskull upon env creation, this reduces the docs by one line, and also makes it faster to run
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Activate this new environment : `conda activate MY_ENV`. | ||
- Run `conda install -c conda-forge grayskull` to install `grayskull`. | ||
- Followed by `grayskull pypi --strict-conda-forge YOUR_PACKAGE_NAME` to generate the recipe. Replace `YOUR_PACKAGE_NAME` with the package name. | ||
- Create a new environment named e.g. "grayskull" with grayskull installed : `conda create --name grayskull -c conda-forge grayskull` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a different name for the env. grayskull_env
or similar to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, conda create ...
+ conda activate ...
is very common in the ecosystem. It's true that conda run
saves one command, but it comes its overheads too (see the output capture issue).
I'd rather have this mentioned as an alternative way of achieving the same thing. It would be a good way of educating the community as well, because this mini tutorial is usually an entry point for beginners.
Something like
[ ORIGINAL INSTRUCTIONS ]
Alternatively, you can save yourself one command and use
conda run
to executegrayskull
. In other words:
- Create an environment with
grayskull
:... command here ...
- Run grayskull from that new environment:
... command here ...
.
WDYT? I'd be more comfortable approving this variant that currently presented one.
Co-authored-by: jaimergp <[email protected]>
grayskull
makes sense if it's justgrayskull
that's installed there.conda run -n grayskull
to avoid having to activate the created environment, saving yet another line and a few keystrokes