added docs for swapfile switch #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Jul 26, 2023
src/maintainer/conda_forge_yml.rst
Outdated
| @@ -79,6 +79,9 @@ mapping for Azure-specific configuration options. For example: | |||
| # toggle for freeing up some extra space on the default Azure Pipelines | |||
| # linux image before running the Docker container for building | |||
| free_disk_space: False | |||
| # toggle for creating a 10G swap file on the default Azure Pipelines | |||
| # linux image before running the Docker container for building | |||
| make_10G_swap: False | |||
There was a problem hiding this comment.
Wonder if we should allow the size to be customizable. Something like this perhaps?
Suggested change
| make_10G_swap: False | |
| linux_swap_size: 10Gb |
There was a problem hiding this comment.
Yes this is a great idea, the default can be zero and if it is zero it just skips that whole block, but if greater than zero we make a swap file of that size
There was a problem hiding this comment.
Yeah actually default of 0 makes more sense. Let's go with that
|
Thanks Mike! 🙏 Had some thoughts on how the configuration could be presented |
1 task
jakirkham
reviewed
Jul 27, 2023
jakirkham
approved these changes
Aug 29, 2023
|
Thanks Mike! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
This PR is for adding docs if conda-forge/conda-smithy#1751 is merged