Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-forge intro modified #1671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

conda-forge intro modified #1671

wants to merge 1 commit into from

Conversation

shreya024
Copy link

@shreya024 shreya024 commented Mar 31, 2022 •
edited
Loading

Fixes: #1277

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@beckermr

@shreya024 shreya024 requested a review from a team as a code owner March 31, 2022 15:49
beckermr
beckermr reviewed Apr 2, 2022
View reviewed changes
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We won’t merge right away though. Thank you!

@shreya024
Copy link
Author

This looks good. We won’t merge right away though. Thank you!

Okay.Thank you so much for the review

kathatherine
kathatherine reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than that one typo.

src/user/introduction.rst Outdated
@@ -8,8 +8,7 @@ A brief introduction

What is conda-forge?
--------------------

Conda-forge is a community effort that provides conda packages for a wide range of software.
Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date ,compatible versions of conda packages along with all the required dependencies for the conda package manager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comma's out of place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review.I have fixed it.

ngam
ngam reviewed Apr 4, 2022
View reviewed changes
src/user/introduction.rst Outdated
@@ -8,8 +8,7 @@ A brief introduction

What is conda-forge?
--------------------

Conda-forge is a community effort that provides conda packages for a wide range of software.
Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about noting that it is open source and driven by the community here? It sort of got taken out by the edit. How does this rough edit sound to you?

Suggested change
Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager.
The conda-forge project can be viewed as a compilation of distributions, recipes, and build infrastructure that enable installing and distributing a wide range of software as conda packages. In a single channel, the conda-forge community provides up-to-date, compatible versions of conda packages along with all their required dependencies. Our work is driven by the community to provide packaged software free of charge and in a transparent manner.

kathatherine
kathatherine suggested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rewrite is very nice. Just one change needed!

src/user/introduction.rst Outdated
@@ -8,7 +8,7 @@ A brief introduction

What is conda-forge?
--------------------
Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager.
The conda-forge project can be viewed as a compilation of distributions, recipes, and build infrastructure that enable installing and distributing a wide range of software as conda packages. In a single channel, the conda-forge community provides up-to-date, compatible versions of conda packages along with all their required dependencies. Our work is driven by the community to provide packaged software free of charge and in a transparent manner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "enables", since the subject of this phrase is "compilation".

Copy link
Contributor

@ngam ngam Apr 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could go either way ;) in the edit, I thought the "distributions, recipes, and build infrastructure" are the enabling ones

(but actually, I rephrased it precisely to avoid dealing with the stupid collective nouns, which I hate dealing with LOL :D https://www.britannica.com/dictionary/eb/qa/Collective-Nouns-and-Verb-Agreement)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call @kathatherine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it, but the compilation of them is still doing the enabling. :)

I agree that collective nouns are the worst, though. Go ahead and change it, please, @shreya024.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

kathatherine
kathatherine approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

jaimergp
jaimergp approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but we'll have to discuss in a core call to ensure folks are alright with this messaging.

@jaimergp jaimergp mentioned this pull request Jun 22, 2023
Open
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 12d36ad
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/65dc9aaa1340760008c7bf71
😎 Deploy Preview https://deploy-preview-1671--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp jaimergp added the Docs label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngam ngam ngam left review comments

@beckermr beckermr beckermr left review comments

@kathatherine kathatherine kathatherine approved these changes

@jaimergp jaimergp jaimergp approved these changes

Assignees
No one assigned
Labels
Docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A proper definition of 'conda-forge'.
5 participants
@shreya024 @jaimergp @beckermr @ngam @kathatherine