Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain QCSubmit against QCElemental Pydantic v2 migration #871

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Oct 4, 2024

This is yet another case of constraining 0.x upstreams against changes propagating out from the Pydantic v2 breaks

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.
$ python recipe/show_diff.py --subdirs noarch       15:30:00  ☁  qcsubmit-qcelemental-pydantic-migration ☀ 𝝙
================================================================================
================================================================================
noarch

@mattwthompson mattwthompson requested a review from a team as a code owner October 4, 2024 20:32
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mattwthompson mattwthompson changed the title Constrain against QCElemental Pydantic v2 migration Constrain QCSubmit against QCElemental Pydantic v2 migration Oct 7, 2024
@xhochy
Copy link
Member

xhochy commented Oct 7, 2024

The diff in CI is not showing any changes.

@mattwthompson
Copy link
Member Author

Hmm thanks ... will have a closer look

@mattwthompson mattwthompson marked this pull request as draft October 7, 2024 19:03
@mattwthompson
Copy link
Member Author

The script to locally diff things isn't working as expected; I've tried a few dozen combinations of inputs and everything, including things like below with nearly no restrictions, and everything shows an empty diff locally. This bit in the README leads me to believe it's not really meant to be trusted, so I'll be firing off some stuff to CI to see what works

if:
  name: openff-qcsubmit
  timestamp_lt: 1728401565
  version_le: 0.53
then:
  - add_depends: espaloma

@mattwthompson
Copy link
Member Author

Not sure what I'm doing wrong here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants