Fix getGridRelativeContainingBlock for flow elements #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15389 Bundle Size — 58.21MiB (~-0.01%).39573e6(current) vs d1d46c1 master#15388(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15389 |
Baseline #15388 |
|
|---|---|---|
 Initial JS |
41.18MiB(~-0.01%) |
41.18MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.24% |
0% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4189 |
4189 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.24% |
27.24% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #15389 |
Baseline #15388 |
|
|---|---|---|
| JS |
58.2MiB (~-0.01%) |
58.2MiB |
| HTML |
9.4KiB (-0.21%) |
9.42KiB |
Bundle analysis report Branch fix/grid-relative-containing-blo... Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
approved these changes
Dec 9, 2024
bkrmendy
approved these changes
Dec 10, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** `getGridRelativeContainingBlock` doesn't correctly return the item position for flow elements. It was temporarily patched with the positioning coming from `getGridChildCellCoordBoundsFromCanvas`, but this PR instead fixes it for good, which cascade-solves a bunch of other small bugs. **Fix:** The flow positioning requires _all_ preceding grid items to be available in the grid, so this PR does just that: inject every (ordered!) child into the temporary grid, retrieve the wanted one, and return its bounding box. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
getGridRelativeContainingBlockdoesn't correctly return the item position for flow elements. It was temporarily patched with the positioning coming fromgetGridChildCellCoordBoundsFromCanvas, but this PR instead fixes it for good, which cascade-solves a bunch of other small bugs.Fix:
The flow positioning requires all preceding grid items to be available in the grid, so this PR does just that: inject every (ordered!) child into the temporary grid, retrieve the wanted one, and return its bounding box.
Manual Tests:
I hereby swear that:
Fixes #6712