Parse grid spans, use csstree for placement parsing
#6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15102 Bundle Size — 58.07MiB (+0.01%).0d097d3(current) vs d1d46c1 master#15100(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15102 |
Baseline #15100 |
|
|---|---|---|
 Initial JS |
41.05MiB(+0.02%) |
41.04MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.7% |
18% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4167 |
4167 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.3% |
27.3% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15102 |
Baseline #15100 |
|
|---|---|---|
| JS |
58.07MiB (+0.01%) |
58.06MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/parse-grid-span Project dashboard
Generated by RelativeCI Documentation Report issue
bkrmendy
reviewed
Nov 11, 2024
bkrmendy
reviewed
Nov 11, 2024
bkrmendy
reviewed
Nov 11, 2024
bkrmendy
approved these changes
Nov 11, 2024
seanparsons
approved these changes
Nov 11, 2024
| axis === 'column' ? container.gridTemplateColumns : container.gridTemplateRows | ||
| const maybeLineFromName = | ||
| targetTracks?.type === 'DIMENSIONS' | ||
| ? targetTracks.dimensions.findIndex((dim) => dim.lineName === firstNode.name) |
There was a problem hiding this comment.
beware that this is not up to spec for repeated line names! span lineName seeks for the first index starting from the placement, just lineName I think finds the lastIndex. and if the lineName is used for row-start or column-start, the lookup goes backwards!
There was a problem hiding this comment.
left a comment note so we can tackle this comprehensively in a subsequent PR
balazsbajorics
approved these changes
Nov 12, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** 1. Parsing an element placing does not use `csstree` 2. Spans are not parsed nor represented This is a purely-parsing PR, laying the groundwork to have strategies and interactions play nicely with spanning items. **Fix:** 1. Use `csstree` to parse grid placement 2. Parse `span` coming form parsing props Fixes #6628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
csstreeThis is a purely-parsing PR, laying the groundwork to have strategies and interactions play nicely with spanning items.
Fix:
csstreeto parse grid placementspancoming form parsing propsFixes #6628