Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Pin Outline Positioning #6595

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

seanparsons
Copy link
Contributor

@seanparsons seanparsons commented Oct 29, 2024

Problem:
The blue dashed line indicating the positioning of the element doesn't line up with the grid cell outlines.

Cause:
The dashed line is a border which is slightly shifting the elements used for those.

Fix:
The dashed lines have been shifted back towards the origin by half the thickness of the border.

Screenshot:
image

Commit Details:

  • Shift pin outlines up and to the left by 0.5, scaled to the scale.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Shift pin outlines up and to the left by 0.5, scaled to the scale.
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Try me

Copy link

relativeci bot commented Oct 29, 2024

#14948 Bundle Size — 57.99MiB (~+0.01%).

05fac18(current) vs 916e8b9 master#14947(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14948
     Baseline
#14947
Regression  Initial JS 40.97MiB(~+0.01%) 40.97MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.01% 17.89%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4152 4152
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14948
     Baseline
#14947
Regression  JS 57.98MiB (~+0.01%) 57.98MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/pin-outline-positionProject dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons merged commit 764f258 into master Oct 29, 2024
14 checks passed
@seanparsons seanparsons deleted the fix/pin-outline-position branch October 29, 2024 11:51
liady pushed a commit that referenced this pull request Dec 13, 2024
- Shift pin outlines up and to the left by 0.5, scaled to the scale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants