Don't collapse grids on delete #6519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14722 Bundle Size — 57.94MiB (~+0.01%).594ee40(current) vs 916e8b9 master#14701(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14722 |
Baseline #14701 |
|
|---|---|---|
 Initial JS |
40.94MiB(~+0.01%) |
40.94MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.94% |
17.91% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4145 |
4145 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.32% |
27.32% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14722 |
Baseline #14701 |
|
|---|---|---|
| JS |
57.93MiB (~+0.01%) |
57.93MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/dont-collapse-empty-grid-de... Project dashboard
Generated by RelativeCI Documentation Report issue
balazsbajorics
requested changes
Oct 11, 2024
There was a problem hiding this comment.
this should probably be implemented in trueUpHuggingElements
ruggi
force-pushed
the
feat/dont-collapse-empty-grid-delete
branch
from
bd5e1b9 to
594ee40
Compare
|
closing this as we'll better fix #5525 and put this functionality in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Deleting the last element in a grid should not collapse the empty grid to 0-sizes.
Fix:
If deletion would empty the grid, if the grid lacks at least one dimension then explicitly size the grid based on its frame.
Fixes #6518