Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubborn elements outside visible area indicator arrow #6367

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Sep 13, 2024

Problem:

The elements outside visible area indicator arrow sometimes shows up even when the element is obviously inside the visible area.

Fix:

Use the fresh metadata to detect the elements outside visible area, because otherwise the frame data might be stale on certain interactions (e.g. insertion).

Also, simplified the code by removing some pre-cursor-positioning code that was not relevant anymore.

Before After
Kapture 2024-09-13 at 14 23 17 Kapture 2024-09-13 at 14 24 03

Fixes #6366

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Try me

Copy link

relativeci bot commented Sep 13, 2024

#14217 Bundle Size — 62.63MiB (~-0.01%).

86d12b9(current) vs 916e8b9 master#14213(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14217
     Baseline
#14213
Improvement  Initial JS 45.75MiB(~-0.01%) 45.75MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.68% 21.66%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4385 4385
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.65% 31.65%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14217
     Baseline
#14213
Improvement  JS 62.61MiB (~-0.01%) 62.62MiB
Improvement  HTML 11.12KiB (-0.32%) 11.16KiB

Bundle analysis reportBranch fix/elements-outside-area-refProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit a4ac2e4 into master Sep 13, 2024
16 checks passed
@ruggi ruggi deleted the fix/elements-outside-area-ref branch September 13, 2024 14:26
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

The elements outside visible area indicator arrow sometimes shows up
even when the element is obviously inside the visible area.

**Fix:**

Use the fresh metadata to detect the elements outside visible area,
because otherwise the frame data might be stale on certain interactions
(e.g. insertion).

Also, simplified the code by removing some pre-cursor-positioning code
that was not relevant anymore.

| Before | After |
|---------|-----------|
| ![Kapture 2024-09-13 at 14 23
17](https://github.com/user-attachments/assets/0e9af6f4-7522-4461-a776-ca92cf6aaf21)
| ![Kapture 2024-09-13 at 14 24
03](https://github.com/user-attachments/assets/4a8d9d69-2682-4ae2-b82b-a8d6e8ed8005)
|

Fixes #6366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix elements outside area indicator showing up when it should not
3 participants