Offset distance indicators for grid absolute move #6339
Conversation
#14148 Bundle Size — 62.55MiB (+0.02%).f635a77(current) vs 916e8b9 master#14124(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14148 |
Baseline #14124 |
|
|---|---|---|
 Initial JS |
45.68MiB(+0.03%) |
45.67MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.22% |
21.56% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4381 |
4381 |
| Duplicate Modules |
520 |
520 |
| Duplicate Code |
31.61% |
31.61% |
| Packages |
472 |
472 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14148 |
Baseline #14124 |
|
|---|---|---|
| JS |
62.54MiB (+0.02%) |
62.53MiB |
| HTML |
11.12KiB (-0.32%) |
11.16KiB |
Bundle analysis report Branch feat/grid-absolute-distance Project dashboard
Generated by RelativeCI Documentation Report issue
| return null | ||
| } | ||
|
|
||
| function position( |
There was a problem hiding this comment.
I would suggest maybe positioning them in the middle of the axes (like the blue indicators):
vs
There was a problem hiding this comment.
I don't agree on this one: the positioning at the origin on the element is to better clarify this is an offset (relative to the 0;0 coord of the bounding rectangle)
There was a problem hiding this comment.
though it's not changing this meaning, since the "left" indicator will still be from the left side and the "top" will still be from the top side (they will just be positioned in the middle of the side itself).
but it's very minor and already clear, so np 👍
**Problem:** When doing an absolute move on grid child elements, it would be good to have visual indicators for the current offset from the cell the element resides in. **Fix:** Add top/left indicators during the move. The indicators will follow the target root cell, and adjust their position so they don't go over each other. If the offset is outside of the cell boundaries, additional orthogonal lines will be displayed for clarity. https://github.com/user-attachments/assets/165ffd7b-50fc-4ae5-a146-39daf22acc71 Fixes #6338
Problem:
When doing an absolute move on grid child elements, it would be good to have visual indicators for the current offset from the cell the element resides in.
Fix:
Add top/left indicators during the move.
The indicators will follow the target root cell, and adjust their position so they don't go over each other.
If the offset is outside of the cell boundaries, additional orthogonal lines will be displayed for clarity.
Screen.Recording.2024-09-09.at.13.46.40.mov
Fixes #6338