Only show the Request Access button when the user is logged in #5054
+20
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
changed the title
Job #11050: Bundle Size — 63.2MiB (~+0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
  
Bundle size by type
View job #11050 report View fix/request-access-logged-in branch activity View project dashboard |
|
Performance test results: |
Rheeseyb
requested review from
gbalint,
seanparsons,
Rheeseyb,
balazsbajorics,
liady and
bkrmendy
Rheeseyb
reviewed
Mar 15, 2024
Comment on lines
16
to
17
| projectId?: string | ||
| loggedIn?: boolean |
There was a problem hiding this comment.
Do these need to be optional?
There was a problem hiding this comment.
nah I don't think they do – I adapted to the existing ?: but it makes sense to have them explicit
There was a problem hiding this comment.
fixed in be43df5 (#5054) (and 615d73a (#5054))
Rheeseyb
approved these changes
Mar 15, 2024
seanparsons
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5053
Problem:
The
ProjectNotFoundpage shows theRequest accessbutton if the project is collaborative, but it should only show it if the user is also logged in.Fix:
Add a flag for it. I passed the value coming from the persistence's context – the same could also be done with
getLoginStatedirectly inside the component but it felt more consistent this way.Happy to change it if somebody feels otherwise!