Port over website-next to Remix #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10835: Bundle Size — 61.87MiB (~-0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10835 report View feat/remix-bff-next branch activity View project dashboard |
liady
approved these changes
Mar 7, 2024
|
Performance test results: |
Rheeseyb
reviewed
Mar 7, 2024
utopia-remix/app/components/next.tsx
Outdated
| borderRadius: 5, | ||
| backgroundColor: '#00FC00', | ||
| }} | ||
| // onAccept={enableCookies} |
There was a problem hiding this comment.
Is this meant to still be commented out?
There was a problem hiding this comment.
pfft, good catch it was a remnant of the component fixes. done in 9837e3e (#5008)
Rheeseyb
reviewed
Mar 7, 2024
| @@ -0,0 +1,134 @@ | |||
| import { LinksFunction } from '@remix-run/node' | |||
There was a problem hiding this comment.
Well this page definitely needs updating! But not in this PR :D
Rheeseyb
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5006
Extracted from incremental work on #4987 so not to inflate that diff, and to continue the migration process, this PR ports over the
website-nextpages to Remix.Included:
Excluded:
@heroiconsAdjusted
The port is as straight as possible, without changing anything visually or content-wise (this means also including Tailwind).