Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data picker - dim options that don't match #4921

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Data picker - dim options that don't match #4921

merged 2 commits into from
Feb 19, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Feb 19, 2024 •
edited
Loading

Description

This PR improves that data picker so that options that don't match any control descriptions / the existing property value are dimmed out.

image

@bkrmendy bkrmendy marked this pull request as ready for review February 19, 2024 11:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 19, 2024 •
edited
Loading

Job #10484: Bundle Size — 62.16MiB (~+0.01%).

ad3af4b(current) vs d299c8d master#10476(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10484		      Baseline
Job #10476
Regression  Initial JS 35.21MiB(~+0.01%) 35.21MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.37% 20.35%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4360 4360
No change  Duplicate Modules 494 494
No change  Duplicate Code 30.8% 30.8%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10484		      Baseline
Job #10476
Regression  JS 62.15MiB (~+0.01%) 62.15MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10484 report View feature/dim-prop-values branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit 9333cf6 into master Feb 19, 2024
14 of 15 checks passed
@bkrmendy bkrmendy deleted the feature/dim-prop-values branch February 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@ruggi ruggi ruggi approved these changes

@gbalint gbalint Awaiting requested review from gbalint

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@liady liady Awaiting requested review from liady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @ruggi @balazsbajorics