Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse / Expand objects in data picker #4917

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Collapse / Expand objects in data picker #4917

merged 4 commits into from
Feb 19, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Feb 16, 2024

Add an object collapse arrow to long or deeply nested objects in data picker.
Currently all objects are collapsed by default, unless they are under two levels of indentation, or have less than four keys.
(in order to keep small/shallow objects visible)

Monosnap.screencast.2024-02-16.19-38-20.mp4

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Try me

Copy link

relativeci bot commented Feb 16, 2024

Job #10487: Bundle Size — 62.16MiB (~+0.01%).

dd92d76(current) vs d299c8d master#10486(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10487
     Baseline
Job #10486
Regression  Initial JS 35.21MiB(~+0.01%) 35.21MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.37% 20.35%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4360 4360
No change  Duplicate Modules 494 494
No change  Duplicate Code 30.8% 30.8%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10487
     Baseline
Job #10486
Regression  JS 62.15MiB (~+0.01%) 62.15MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10487 reportView feat/obj-collapse branch activityView project dashboard

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Performance test results:
(Chart1)
(Chart2)

@liady liady requested a review from ruggi February 19, 2024 12:36
@liady liady merged commit f817830 into master Feb 19, 2024
14 checks passed
@liady liady deleted the feat/obj-collapse branch February 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants