Html control with preview #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10457: Bundle Size — 62.15MiB (~+0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10457 report View feature/html-prop-control branch activity View project dashboard |
|
Performance test results: |
bkrmendy
approved these changes
Feb 15, 2024
| @@ -53,31 +53,31 @@ describe('Set element prop via the data picker', () => { | |||
| let currentOption = editor.renderedDOM.getByTestId(VariableFromScopeOptionTestId(0)) | |||
| await mouseClickAtPoint(currentOption, { x: 2, y: 2 }) | |||
| expect(within(theScene).queryByText('Title too')).not.toBeNull() | |||
| expect(within(theInspector).queryAllByText('Title too')).toHaveLength(2) | |||
| expect(within(theInspector).queryByText('Title too')).not.toBeNull() | |||
There was a problem hiding this comment.
it's slowly getting worse, this test :D
There was a problem hiding this comment.
as if to prove my point that testing what is in the UI is not the way to go
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| }} | ||
| title='Hello Utopia' |
There was a problem hiding this comment.
I wouldn't name this Hello Utopia, just to avoid the test text matcher being confused in the future
balazsbajorics
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: