Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFF: fix proxy url for getting default branch #4906

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

balazsbajorics
Copy link
Contributor

Problem:
The route for the default branch url was v1.github.branches.$owner.$repository.branch.default-branch but in reality it's v1.github.branches.$owner.$repository.default-branch

Fix:
Make it v1.github.branches.$owner.$repository.default-branch

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Try me

Copy link

relativeci bot commented Feb 15, 2024

Job #10455: Bundle Size — 62.15MiB (~-0.01%).

f765d79(current) vs d299c8d master#10453(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10455
     Baseline
Job #10453
Regression  Initial JS 35.19MiB(~+0.01%) 35.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.35% 0%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4359 4359
No change  Duplicate Modules 494 494
No change  Duplicate Code 30.8% 30.8%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10455
     Baseline
Job #10453
Regression  JS 62.14MiB (~+0.01%) 62.14MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10455 reportView fix/github-default-branch-url branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@balazsbajorics balazsbajorics merged commit 7d4cdf1 into master Feb 15, 2024
17 checks passed
@balazsbajorics balazsbajorics deleted the fix/github-default-branch-url branch February 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants