sigh

[balazsbajorics]

Problem:
There's a commenting test can reparent comment that is noticeably flaky.

I was looking into what are the most brittle parts of the actual test and one stood out to me:

We move the mouse to trigger an animation and await "animation duration + 1ms". That's a very slim error margin!

Fix:
the REAL fix would be to not use a timer here and actually await the animation to finish.

for now though, I just change this timer to 1 second

[ruggi]

😅

[github-actions]

Try me

[relativeci]

Job #10204: Bundle Size — 62.34MiB (+0.02%).

3cbb61c(current) vs 794431b master#10182(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics   3 changes 2 regressions

	Current Job #10204	Baseline Job #10182
Initial JS	35.38MiB(+0.03%)	35.37MiB
Initial CSS	0B	0B
Cache Invalidation	21.76%	20.18%
Chunks	28	28
Assets	32	32
Modules	4407	4407
Duplicate Modules	490	490
Duplicate Code	30.7%(+0.03%)	30.69%
Packages	462	462
Duplicate Packages	65	65

Bundle size by type   2 changes 1 regression 1 improvement

	Current Job #10204	Baseline Job #10182
JS	62.33MiB (+0.02%)	62.31MiB
HTML	11.37KiB (-0.32%)	11.41KiB

---

View job #10204 report View fix/improve-comment-test-reliabi... branch activity View project dashboard

[github-actions]

Performance test results:

[Rheeseyb]

Yuck! But 👍