only check the icon's name instead of the full icon url including por… #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10181: Bundle Size — 62.32MiB (~-0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10181 report View fix/flaky-jest-toolbar-icon branch activity View project dashboard |
|
Performance test results: |
Rheeseyb
approved these changes
Feb 2, 2024
seanparsons
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Karma tests
Flex Reorder Strategy - normal reorder scenarios - works with normal directionandAbsolute Move Strategy - moves component instances that honour the position propertiesare flakyFix:
Turns out they were checking a toolbar icon's full URL, including the port number, which would sometimes not match.